Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terra-release): disable repodata check to make mirroring work #1301

Closed
wants to merge 1 commit into from
Closed

fix(terra-release): disable repodata check to make mirroring work #1301

wants to merge 1 commit into from

Conversation

madonuko
Copy link
Member

@madonuko madonuko commented May 30, 2024 •
edited
Loading

This is done because not even Fedora enable this! This will cause issues when Terra mirrors are not syncing in real time, causing dnf to think Terra is broken when hashes don't match with tetsudou.

@madonuko madonuko enabled auto-merge (squash) May 30, 2024 09:50
@madonuko madonuko requested a review from nothingneko May 30, 2024 16:23
@lleyton
Copy link
Member

lleyton commented May 30, 2024

Please don’t merge this yet, want to test some stuff. Albeit, isn’t the repomd verified using the metalink hash? Unsure if switching this to 0 changes that

@korewaChino
Copy link
Contributor

Please don’t merge this yet, want to test some stuff. Albeit, isn’t the repomd verified using the metalink hash? Unsure if switching this to 0 changes that

iirc the repomd is only used from upstream, they only mirror the big RPM files so if that fails it will just try another mirror

@lleyton
Copy link
Member

lleyton commented May 31, 2024 •
edited
Loading

If that's the case, I don't see how this change is necessary

@madonuko
Copy link
Member Author

madonuko commented Jun 1, 2024

If that's the case, I don't see how this change is necessary

No, that's exactly why this change is necessary.

Without this, dnf would only choose repos.fyralabs.com because that's the only mirror deemed to have "the correct hash" by dnf.

@madonuko madonuko closed this Jun 27, 2024
auto-merge was automatically disabled June 27, 2024 05:31

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nothingneko nothingneko Awaiting requested review from nothingneko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madonuko @lleyton @korewaChino